Andrushika commented on code in PR #74589: URL: https://github.com/apache/airflow/pull/74589#discussion_r4260963511
########## contributing-docs/18_contribution_workflow.rst: ########## @@ -325,3 +309,39 @@ on your PR and mention that you think it is ready to be merged. Also, it's a goo to latest ``main``, because there could be other changes merged in the meantime that might cause conflicts or fail tests or static checks, so by rebasing a PR that has been build few days ago you make sure that it still passes the tests and static checks today. + + +Newsfragments +------------- + +Newsfragments are only consumed by ``airflow-core/``, ``chart/`` and ``dev/mypy/``. Do not add one by default. + +For ``airflow-core/`` (including ``task-sdk/``, which ships with ``airflow-core``), use only ``significant`` +newsfragments, and only for a change users must read before upgrading: + +* a behaviour change, a removal or a new default, +* a change that needs migration steps, +* a change that cannot be explained in the one-line commit title. Review Comment: Removed this line. This was to align with the discussion on the dev list: <img width="1080" height="458" alt="image" src="https://github.com/user-attachments/assets/4a78fadb-50b7-4063-bd5e-33586484f8fc"; /> But yes, I agree it's too broad -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
