kadubhumika commented on PR #74602: URL: https://github.com/apache/airflow/pull/74602#issuecomment-6150383943
@yuseok89 Thanks for the review! I looked into whether the AioRpcError handler could be reached through this code path. The async Google API client translates underlying gRPC errors into google.api_core.exceptions, so an UNAVAILABLE response is surfaced as ServiceUnavailable. I removed the redundant AioRpcError handling and its associated tests, keeping the retry logic for ServiceUnavailable. I also restored the original formatting of the Batch.State condition. What i changed actuualy Error handling: Kept retries for ServiceUnavailable, which represents a temporary service outage. Removed redundant handling: Removed the raw AioRpcError branch because the Google API client translates gRPC errors in this call path. Tests: Removed the two tests that specifically exercised the deleted raw-gRPC exception handler. Formatting: Restored the Batch.State condition to a single line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
