kadubhumika commented on PR #74602: URL: https://github.com/apache/airflow/pull/74602#issuecomment-6176948203
Thanks for the suggestion, @moIcay like this approach. Using Tenacity and following the existing Google provider retry patterns, potentially in the Dataproc Hook, sounds like a cleaner solution. I'll work on updating the implementation, run the relevant tests, and push the revised changes once everything is verified. Thanks again for the guidance! On Thu, Oct 15, 2026, 12:28 AM M. Olcay Tercanlı ***@***.***> wrote: > ***@***.**** requested changes on this pull request. > ------------------------------ > > In > providers/google/src/airflow/providers/google/cloud/triggers/dataproc.py > <https://github.com/apache/airflow/pull/74602#discussion_r4274988861>: > > > @@ -651,13 +651,22 @@ async def run(self): > hook = self.get_async_hook() > > while True: > - batch = await hook.get_batch( > - project_id=self.project_id, region=self.region, batch_id=self.batch_id > - ) > + try: > > What about using @retry decorator from tenacity library which we are > using across all google provider for retry? > Also the decorator can be placed in the Hook code instead of Operator code. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/airflow/pull/74602?email_source=notifications&email_token=BMB777OMJ3KYVJJK7BAXPWD5T7EFRA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKNJSGMYTCMBRGAZKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#pullrequestreview-5523110102>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/BMB777MXMLJM2MC3GJP4DUD5T7EFRAVCNFSNUABEKJSXA33TNF2G64TZHMZTGOBYGQ4DSMJ3JFZXG5LFHM2TQMJWG4ZTGNBYGGQXMAQ> > . > Triage notifications, keep track of coding agent tasks and review pull > requests on the go with GitHub Mobile for iOS > <https://github.com/notifications/mobile/ios/BMB777N2G46DJK2NWFHKE4T5T7EFRA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKNJSGMYTCMBRGAZKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG> > and Android > <https://github.com/notifications/mobile/android/BMB777LFHCG56DPPFHAPDJD5T7EFRA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKNJSGMYTCMBRGAZKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>. > Download it today! > You are receiving this because you authored the thread.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
