JelyFishhhhhh commented on code in PR #73797:
URL: https://github.com/apache/airflow/pull/73797#discussion_r4265838922
##########
airflow-core/src/airflow/providers_manager.py:
##########
@@ -270,6 +270,21 @@ class ConnectionFormWidgetInfo(NamedTuple):
is_sensitive: bool
+def _is_sensitive_form_field(field: Any) -> bool:
Review Comment:
You're right: the field is unbound, so `field.field_class.widget` is always
the class default, and a subclass is already rejected by the
`allowed_field_classes` check. I've reverted to the original expression and
removed that sentence from the description.
I also dropped the `asb.py` widget change. It doesn't affect `is_sensitive`,
and the UI takes the password format for a hook widget from its field class,
not its widget.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
