JelyFishhhhhh commented on code in PR #73797:
URL: https://github.com/apache/airflow/pull/73797#discussion_r4265839071
##########
shared/secrets_masker/src/airflow_shared/secrets_masker/secrets_masker.py:
##########
@@ -54,24 +54,33 @@ def to_dict(self) -> dict[str, Any]: ...
"access_token",
"api_key",
"apikey",
+ "app_key",
"auth_header",
"authorization",
"bearer",
+ "certificate",
"connection_string",
+ "credential",
Review Comment:
Agreed, and it was wider than those two: the new names also matched
`certificate_data`, `certificate_path`, `SSLServerCertificate`,
`credential_pem_file`, `extra_credential` and `service_principal_oauth` in
other providers.
They are now a separate `DEFAULT_SENSITIVE_FIELD_NAMES` set, matched against
the whole field name and its `extra__<conn_type>__<name>` form, so none of
those match any more. `test_hiding_whole_field_names` fails against main and
against the earlier substring version.
I kept this to the allowlist rather than switching to the `format: password`
declarations. That changes where the masker gets its field list from, so it
seems better as a separate change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
