Lee-W commented on code in PR #74694:
URL: https://github.com/apache/airflow/pull/74694#discussion_r4269338010


##########
providers/common/ai/docs/changelog.rst:
##########
@@ -25,6 +25,12 @@
 Changelog
 ---------
 
+.. note::
+  ``LoggingToolset`` is no longer part of the public API and is no longer 
exported from

Review Comment:
   changed it to `airflow.providers.common.ai.toolsets.logging.LoggingToolset` 
(shipped in 0.10.0, now an `ImportError`) and gives `Agent(..., 
capabilities=[ToolLoggingCapability()])` as the replacement



##########
providers/common/ai/src/airflow/providers/common/ai/operators/agent.py:
##########
@@ -277,7 +277,7 @@ class AgentOperator(CancellableAgentRunMixin, BaseOperator, 
HITLReviewMixin, Usa
         in the serialized Dag, and cannot be combined with this argument (the
         task fails when it runs).
     :param enable_tool_logging: When ``True`` (default), wraps the agent's
-        assembled function toolset in a ``LoggingToolset`` that logs tool calls
+        assembled function toolset in a ``ToolLoggingCapability`` that logs 
tool calls

Review Comment:
   Reworded in `agent.py` and `operators/agent.rst`: the operator appends a 
`ToolLoggingCapability`, and an existing one in `capabilities` is used instead 
of adding a second.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to