gopidesupavan commented on code in PR #74591:
URL: https://github.com/apache/airflow/pull/74591#discussion_r4276648124


##########
providers/snowflake/docs/connections/snowflake.rst:
##########
@@ -77,6 +77,11 @@ Extra (optional)
     * ``token_file_path``: Path to a file holding the OIDC ID token used when 
``workload_identity_provider``
       is ``OIDC``. The connector reads the token from this file, which suits 
projected or rotated tokens
       (for example a Kubernetes service-account token).
+    * ``workload_identity_impersonation_path``: The chain of identities to 
impersonate, in order, before
+      authenticating with Workload Identity Federation, as a list or a 
comma-separated string (not a file path;
+      the name matches the connector parameter). For ``AWS``, IAM role ARNs 
that the workload's credentials
+      assume in turn; for ``GCP``, service account emails. Snowflake then 
trusts the last identity in the chain
+      instead of the workload's own. Requires 
``snowflake-connector-python>=4.0.0``.

Review Comment:
   The docs say “Requires >=4.0.0”, but nothing enforces it. Could we either 
raise exception in the hook



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to