gopidesupavan commented on code in PR #74591:
URL: https://github.com/apache/airflow/pull/74591#discussion_r4276703378
##########
providers/snowflake/src/airflow/providers/snowflake/hooks/snowflake.py:
##########
@@ -572,6 +576,13 @@ def _add_workload_identity_config(
if token_file_path:
conn_config["token_file_path"] = token_file_path
+ impersonation_path = self._get_field(extra_dict,
"workload_identity_impersonation_path")
+
+ if impersonation_path:
Review Comment:
may be?
```
if isinstance(impersonation_path, str):
impersonation_path = impersonation_path.split(",")
if not isinstance(impersonation_path, list):
raise ValueError("workload_identity_impersonation_path must be a list or
a comma-separated string")
impersonation_path = [str(step).strip() for step in impersonation_path if
str(step).strip()]
if impersonation_path:
conn_config["workload_identity_impersonation_path"] = impersonation_path
```
include list aswell its better to validate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
