potiuk commented on code in PR #74696:
URL: https://github.com/apache/airflow/pull/74696#discussion_r4308139398
##########
pyproject.toml:
##########
@@ -119,7 +119,7 @@ apache-airflow = "airflow.__main__:main"
"apache-airflow-providers-apache-beam>=5.8.1"
]
"apache.cassandra" = [
- "apache-airflow-providers-apache-cassandra>=3.7.0; python_version
!=\"3.14\""
+ "apache-airflow-providers-apache-cassandra>=3.7.0"
Review Comment:
Dropping the `python_version != "3.14"` guard while the floor stays at
`>=3.7.0` (and `>=0.1.0` for vespa) means `apache-airflow[all]`,
`[apache.cassandra]` or `[vespa]` on 3.14 can resolve only to provider releases
that exclude 3.14, so the install fails until the next providers wave. Either
keep the guard until those releases are on PyPI, or raise the floors to the
next provider versions in the same PR.
##########
providers/apache/cassandra/pyproject.toml:
##########
@@ -59,6 +60,7 @@ requires-python = ">=3.11,!=3.14.*"
dependencies = [
"apache-airflow>=2.11.0",
"apache-airflow-providers-common-compat>=1.8.0",
+ "cassandra-driver>=3.30.1; python_version >= '3.14' and python_version <
'3.15'",
Review Comment:
Every `cassandra-driver` line is now capped by a `python_version` marker,
while `requires-python` is open-ended `>=3.11`. On Python 3.15 the provider
installs without the driver at all, and importing `CassandraHook` fails.
Leaving the newest line open-ended avoids the gap:
```suggestion
"cassandra-driver>=3.30.1; python_version >= '3.14'",
```
##########
providers/vespa/pyproject.toml:
##########
@@ -59,7 +60,7 @@ requires-python = ">=3.11,!=3.14.*"
dependencies = [
"apache-airflow>=2.11.0",
"apache-airflow-providers-common-compat>=1.12.0",
- "pyvespa>=1.1.2",
+ "pyvespa>=1.2.9",
Review Comment:
Only 3.14 needs pyvespa 1.2.9; raising the floor for every Python version
forces an upgrade (or a resolver conflict) on 3.11-3.13 users. Mirroring the
Cassandra approach keeps it to 3.14:
```suggestion
"pyvespa>=1.2.9; python_version >= '3.14'",
"pyvespa>=1.1.2; python_version < '3.14'",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
