dheerajturaga opened a new pull request, #75043:
URL: https://github.com/apache/airflow/pull/75043

   ### Stack
   
   Stacks on #75042. Stack index: 11 of 20.
   
   A PR from a fork cannot target a fork branch, so each PR in the stack is 
based on `main` and contains every commit below it; only the top commit is new. 
Review only the commit "AIP-125: Add a webhook deliveries page to the UI"; the 
commits below it belong to earlier PRs in the stack.
   
   ### Status
   
   Draft. [AIP-125 (Inbound 
Webhooks)](https://lists.apache.org/thread/p3dpnor4zwko8tldpncj6ftj1bpp18q7) is 
under discussion on dev@ and not yet voted; this stack is its proof of concept 
so that voters can run it, and nothing should merge before the vote. The 
feature is opt-in (only `airflow api-server --apps webhooks` serves deliveries) 
and experimental; no unauthenticated route is reachable until stack PR 18, 
which merges last.
   
   ### Why
   
   Deployment Managers checking why a webhook started nothing should not need 
the REST API to see what it received and what Airflow did with it. The page 
lives at `/webhook_deliveries/<name>`, never under `/webhooks`, which the API 
server serves for inbound webhooks. It takes its filters from the URL so that 
asset events can link to one delivery, and it is reached from the webhook's 
connection rather than a menu item that FAB would hide.
   
   ### What to look at
   
   - The route's placement, and the "View Deliveries" row action on 
Connections, shown only for an `inbound_webhook` connection named 
`webhook_<valid name>`.
   - URL filters: id, delivery id, outcome, correlation key and received-at 
range.
   - English strings only. No payload is shown, matching the API.
   
   ### Testing
   
   - New vitest suites for `WebhookDeliveries` and 
`ViewWebhookDeliveriesButton`, and the `documentTitle` suite, passed on the 
host.
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code (Opus 5.5)
   
   Generated-by: Claude Code (Opus 5.5) following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
 You can add this file in a follow-up commit after the PR is created so you 
know the PR number.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to