seanghaeli commented on PR #71850: URL: https://github.com/apache/airflow/pull/71850#issuecomment-6278678426
Thanks for the changes. I am seeing another issue. After this PR goes in, this will be the first time a user's `_evaluate_with` runs during a clear, and if it raises, the whole clear fails (I got a 500 from the clear API with a reference reading a deleted Variable). Can you move this within the try/except block here, and catch `Exception` rather than just `ValueError`/`TypeError`: https://github.com/apache/airflow/blob/b12a9e8ecdbd8d045c714bc02dce453d72a1cd6d/airflow-core/src/airflow/models/taskinstance.py#L294-L317 and add a small test with a reference that raises an exception? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
