kaxil commented on code in PR #75188:
URL: https://github.com/apache/airflow/pull/75188#discussion_r4323344026
##########
providers/common/ai/tests/unit/common/ai/sandbox/test_modal.py:
##########
@@ -144,7 +144,10 @@ def
test_create_accepts_every_argument_the_backend_passes(self, real_modal):
def test_the_calls_behind_the_tools_still_exist(self, real_modal):
import inspect
- from modal.sandbox import _SandboxFilesystem
+ try:
+ from modal.sandbox._filesystem import _SandboxFilesystem
+ except ImportError: # modal < 1.6 keeps it in a flat module
+ from modal.sandbox import _SandboxFilesystem
Review Comment:
Here's the annotation version. I ran this test's asserts against it on
1.5.2, 1.5.5, 1.6.0, 1.6.1 and 1.6.2 and they pass on all five.
```suggestion
# Not imported: the private module path changed in modal 1.6.2.
_SandboxFilesystem =
inspect.signature(real_modal.Sandbox.filesystem.fget).return_annotation
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
