potiuk commented on code in PR #74820:
URL: https://github.com/apache/airflow/pull/74820#discussion_r4330953723
##########
dev/breeze/src/airflow_breeze/commands/ci_commands.py:
##########
@@ -286,7 +287,18 @@ def selective_check(
github_context = github_context_input.read()
github_context_dict = json.loads(github_context) if github_context
else {}
github_event = GithubEvents(github_event_name)
- if commit_ref is not None:
+ fork_push = is_fork_push(github_event, github_repository)
Review Comment:
Fixed. A fork push now reads the labels of the open apache/airflow pull
request for `<fork-owner>:<branch>`, so `full tests needed`, `allow provider
dependency bump`, `skip common compat check` and the rest work in fork CI. A
label added later takes effect on the next fork run.
---
Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting
##########
dev/breeze/src/airflow_breeze/utils/selective_checks.py:
##########
@@ -2292,7 +2322,7 @@ def provider_dependency_bump(self) -> bool:
FileGroupForCi.ALL_PYPROJECT_TOML_FILES,
CI_FILE_GROUP_MATCHES,
)
- if not pyproject_files or not self._github_event ==
GithubEvents.PULL_REQUEST:
+ if not pyproject_files or not self._is_pull_request_like():
Review Comment:
Fixed differently than skipping, so the check still runs for gated PRs. On a
fork push, the previous version of each `pyproject.toml` now comes from the
compare's merge base in apache/airflow, not from `commit_ref^`. A release
manager's bump merged in from `main` no longer counts as the contributor's. The
root `pyproject.toml` check uses the same path. A file missing at the merge
base counts as new. Any other read failure fails selective checks rather than
letting the check pass unseen. Test:
`test_provider_dependency_bump_on_a_fork_push_compares_with_the_merge_base`.
---
Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
