xBis7 commented on code in PR #74046:
URL: https://github.com/apache/airflow/pull/74046#discussion_r4336638432
##########
shared/observability/src/airflow_shared/observability/metrics/otel_logger.py:
##########
@@ -481,7 +485,11 @@ def get_otel_logger(
otel_env_config = load_metrics_env_config()
effective_service_name: str = otel_env_config.service_name or service_name
or "airflow"
- resource = Resource.create(attributes={SERVICE_NAME:
effective_service_name})
+ resource_attributes = {SERVICE_NAME: effective_service_name}
+ if service_instance_id:
Review Comment:
It is, but it's decided at the caller. The caller checks the environment and
if the user has provided a value, then this is `None`. If there isn't a value,
this gets a fixed one which is then set here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
