xBis7 commented on code in PR #74046:
URL: https://github.com/apache/airflow/pull/74046#discussion_r4339689581
##########
airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.py:
##########
@@ -787,6 +803,26 @@ def _build_rejected_gate_payload(
return TITerminalStatePayload(state=TerminalStateNonSuccess.FAILED,
retry_reason=reason, **carried)
+def _emit_task_finish_metrics(
Review Comment:
These aren't new. These are the old ones that have been moved.
Statsd has an option to disable tags
https://github.com/apache/airflow/blob/main/airflow-core/src/airflow/config_templates/config.yml#L1328-L1336
```
statsd_disabled_tags:
description: |
If you want to avoid sending all the available metrics tags to
StatsD,
you can configure a block list of prefixes (comma separated) to
filter out metric tags
that start with the elements of the list (e.g: ``job_id,run_id``)
version_added: 2.6.0
type: string
example: job_id,run_id,dag_id,task_id
default: job_id,run_id
```
what if we do the same for OTel? That way it's up to the users whether they
want the cardinality or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
