shahar1 commented on PR #75001: URL: https://github.com/apache/airflow/pull/75001#issuecomment-6334058208
Thanks for the reviews. The branch is rebased onto main, and the changes are in e721ac97e3..8cec2d98fa. Review summary points, in order: 1. Read-only mount: no change. The theme builds with `flit_core` (`build-backend = "flit_core.buildapi"` in `airflow-site/sphinx_airflow_theme/pyproject.toml`), which does not write `*.egg-info` or `build/` into the source folder. It was run end to end with a real airflow-site checkout: a marker in `layout.html` showed up in the built HTML. The install was also checked against a read-only mount in the CI image. 2. `--no-deps` is replaced with `--reinstall-package sphinx-airflow-theme`. Only the theme is reinstalled, and a dependency that the theme adds is installed too. 3. `--sdk-docs-only` together with `--sphinx-airflow-theme-path` is now rejected with a usage error. 4. The `_gen` check is now a click callback that raises `click.BadParameter`. The help text says the path is the `sphinx_airflow_theme` sub-folder, not the airflow-site root. 5. `run_docs_build.sh` now installs the theme only when `SPHINX_AIRFLOW_THEME_PATH` is set. 6–7. Both build-docs test classes now share one fixture that stubs Docker with autospecced mocks and points `AIRFLOW_ROOT_PATH` to `tmp_path`. Before, the existing Python-version test deleted the real `generated/**/apis` folders. 8. The tests assert `exit_code == 0` before reading `call_args`. The rejection tests also check the error text, so they fail without the new option. Follow-up issue for the auto-rebuild mode asked for on #70139: #75374. --- Drafted-by: Claude Code (Opus 5.5) (no human review before posting) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
