jedcunningham opened a new pull request, #75433:
URL: https://github.com/apache/airflow/pull/75433
The Occurrences column on the Dag version comparison carries no information
for anyone who can see values, which is the overwhelmingly common case: there
every record stands for exactly one change, so the column is a row of 1s. Even
when values are hidden, a record only merges changes when its path hides a
task, tag or group behind `*` (or for `custom_fields`). This removes the column
and shows the count only where it says something: an outlined `×N` badge after
the path, with a tooltip ("N changes share this path"). A truncated diff shows
`×N+` and "At least N changes ...", since its counts are lower bounds.
- `VersionDiff.tsx`: drop the `occurrence_count` column and pass the count
and `truncated` to `PathText`.
- `PathText.tsx`: render the badge when the count is above 1. It is outlined
purple so it stands apart from the impact and "Values hidden" badges.
- i18n: remove `versions.columns.occurrences` from all locales and add
plural `pathOccurrences` / `pathOccurrencesAtLeast` keys in English.
- Tests: badge shown for a merged record, `+` when truncated, no badge when
values are visible. Cell-index assertions are updated for the removed column.
The API is unchanged; `total_changes` still sums `occurrence_count` for the
summary.
*Screenshots:*
Before:
<img width="1400" height="600" alt="preview-before-with-values"
src="https://github.com/user-attachments/assets/b3913248-dd46-420d-9731-50b4fc62dc9a";
/>
(redacted)
<img width="1400" height="600" alt="preview-before-redacted"
src="https://github.com/user-attachments/assets/336cd565-033e-457d-b68a-01499faf80e6";
/>
After:
<img width="1400" height="700" alt="preview-diff-with-values"
src="https://github.com/user-attachments/assets/0b475c59-c383-4f74-bd9a-c870315e4cd5";
/>
(redacted)
<img width="1400" height="600" alt="preview-badge-dark"
src="https://github.com/user-attachments/assets/150067a0-2306-4a84-96a5-ff385a8c73a0";
/>
(redacted light mode)
<img width="1400" height="600" alt="preview-badge-light"
src="https://github.com/user-attachments/assets/13995c02-c5af-406e-80c8-97175f68328e";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
