ephraimbuddy commented on code in PR #74794:
URL: https://github.com/apache/airflow/pull/74794#discussion_r4361036543
##########
airflow-core/src/airflow/cli/cli_config.py:
##########
@@ -2304,6 +2304,21 @@ class GroupCommand(NamedTuple):
help="Start a dag processor instance",
func=lazy_load_command("airflow.cli.commands.dag_processor_command.dag_processor"),
args=(
+ Arg(
+ ("--check-health",),
+ action="store_true",
+ help="Check the API-mode processor's local loop heartbeat and
exit",
+ ),
+ Arg(
+ ("--check-ready",),
+ action="store_true",
+ help="Check the API-mode processor's loop and API heartbeat
and exit",
+ ),
+ Arg(
+ ("--sync-bundles-only",),
Review Comment:
A separate command would make the trusted operation easier to discover. My
preference is to keep `--sync-bundles-only` for this change: it reuses the
processor's bundle configuration and `--bundle-name` selection, synchronizes
once, and exits before starting a processor or entering its API-mode lifecycle.
I clarified the flag's help and deployment docs: run it on a trusted host
with database access and the Fernet key used to sign bundle URLs, regardless of
whether `execution_api_token_file` is configured. Token provisioning separately
needs JWT signing keys and does not access the database. The API-mode processor
should receive none of those credentials. This proposes retaining the flag with
the clarified deployment boundary; the separate command has not been
implemented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
