Andrushika commented on code in PR #75612:
URL: https://github.com/apache/airflow/pull/75612#discussion_r4371479156
##########
.github/workflows/ci-amd.yml:
##########
@@ -423,6 +424,30 @@ jobs:
env:
SKIP_BREEZE_SELF_UPGRADE_CHECK: "true"
GITHUB_CONTEXT_INPUT: "${{ runner.temp }}/github_context.json"
+ # The newsfragment check of static checks fails a newsfragment of the
pull request that is
+ # named after another number. A push in a fork (AIP-120) has no pull
request in its event,
+ # so the open pull request of the pushed branch is looked up; without
one, any number passes.
+ - name: "Find the pull request for the newsfragment check"
+ id: newsfragment-pr
+ env:
+ GH_TOKEN: ${{ github.token }}
+ EVENT_NAME: ${{ github.event_name }}
+ BASE_REF: ${{ github.base_ref }}
+ EVENT_PR_NUMBER: ${{ github.event.pull_request.number }}
+ REPOSITORY: ${{ github.repository }}
+ OWNER: ${{ github.repository_owner }}
+ REF_NAME: ${{ github.ref_name }}
+ run: |
+ number=""
+ if [[ "${EVENT_NAME}" == "pull_request" && "${BASE_REF}" == "main"
]]; then
Review Comment:
Nit: We might need `&& "${REPOSITORY}" == "apache/airflow"` here and in
`ci-arm.yml`. A `pull_request` run inside a fork has the fork's PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
