HsuehYi commented on code in PR #75504:
URL: https://github.com/apache/airflow/pull/75504#discussion_r4377454074
##########
airflow-core/src/airflow/ui/public/i18n/locales/zh-TW/common.json:
##########
@@ -229,8 +229,8 @@
"receivedAssetEvents": "收到的資源事件"
},
"pause": "暫停",
- "pendingDagRun_one": "{{count, number}} 個待執行的 Dag 執行",
- "pendingDagRun_other": "{{count, number}} 個待執行的 Dag 執行",
+ "pendingDagRun_one": "1 個待處理的 Dag 執行",
+ "pendingDagRun_other": "{{count, number}} 個待處理的 Dag 執行",
Review Comment:
Good question — the remaining `pending` strings mean different things, so
one translation doesn't fit all of them.
**`common:states.pending` (callback state)** — keep 待處理. The lifecycle is
`pending → queued → running → success / failed`, and `queued` is already 排隊中.
If `pending` also read 待執行, the two would be nearly indistinguishable in
filters and badges, while the real difference is "not in the queue yet" vs
"queued and waiting for a worker" (the UI even renders `pending` with the
scheduled badge style). A state label describes which bucket something is in,
not what happens next.
**`browse:deadlines.filters.statusOptions.pending`** — the filter has
exactly two options, `missed = false` and `missed = true`. A deadline is a
"need-by" time: the row is pruned when the Dag run finishes before it, and the
scheduler sets `missed = true` when the time passes without finishing. So the
label means "not missed yet". 待執行 would be wrong (a deadline isn't executed),
and 待處理 also pairs oddly with 已逾期. I'd suggest changing it to 未逾期, which pairs
with 已逾期. Of the 17 locales that have this string, only Korean uses 예정
("upcoming") — the other 16 translate it literally as "pending". So this would
be a deliberate deviation, but I think it is the accurate label here.
`pendingDagRun` is different from both: the string itself is the sentence "N
Dag runs waiting to execute", and the list it labels only contains runs that
are about to run, so 待執行 is the accurate wording there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
