ChickenBenny commented on code in PR #75561: URL: https://github.com/apache/airflow/pull/75561#discussion_r4386126821
########## task-sdk/src/airflow/sdk/coordinators/_subprocess.py: ########## Review Comment: Thanks for taking care of these! Found one thing though, the new docstring contract doesn't work on the native Dag path yet. `_build_native_task_command` catches everything from `_build_dag_file_command`: https://github.com/apache/airflow/blob/c385eff4dbcff65b1b0baf17bf757bac4fcac518/task-sdk/src/airflow/sdk/coordinators/_subprocess.py#L859-L864 So if a subclass raises `TaskLaunchError(..., retryable=False)` like the docstring says, it gets wrapped again into a new `TaskLaunchError` with the default `retryable=True`. The task ends up retrying anyway. Just need to let it through first, like `_raise_as_launch_error` does: ```python except TaskLaunchError: raise -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
