justinpakzad commented on code in PR #74943:
URL: https://github.com/apache/airflow/pull/74943#discussion_r4395573251
##########
task-sdk/src/airflow/sdk/io/path.py:
##########
@@ -463,7 +463,7 @@ def move(self, path: str | ObjectStoragePath, recursive:
bool = False, **kwargs)
# non-local copy
self.copy(path, recursive=recursive, **kwargs)
- self.unlink()
+ self.fs.rm(self.path, recursive=recursive)
Review Comment:
Good call, a ValueError is now raised when the destination is the source or
inside it. Test cases were added to cover the new behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
