justinpakzad commented on PR #74943: URL: https://github.com/apache/airflow/pull/74943#issuecomment-6457816570
> Thanks for the fix. Streaming each file to `dst / src_obj.key` fixes the remote-to-remote case: `mkdir()` does nothing on object stores, so every file used to overwrite `dst`. Using `fs.rm` also lets a directory `move` get past `unlink()`. A few comments inline, mostly about the new recursive delete. > > Could you also rebase onto current `main`? The required `CI passed` check was added after this PR's last CI run, so it will stay "Expected" until a new run starts. Appreciate the review! I've addressed all of your comments and rebased as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
