uranusjr commented on code in PR #75446:
URL: https://github.com/apache/airflow/pull/75446#discussion_r4397214794
##########
task-sdk/src/airflow/sdk/execution_time/supervisor.py:
##########
@@ -2005,11 +2028,13 @@ def _handle_execution_timeout_if_needed(self):
For a Python task, ``StartExecutionTimeout`` arms the deadline right
before ``execute()``, so bundle
loading and Dag parsing are not covered; Dag parsing has its own
``dagbag_import_timeout``. For a
task a language SDK runs, it is armed once the runtime has been sent
``StartupDetails``. Either
- way, the process is sent SIGTERM ``killed_task_cleanup_time`` after
the timeout elapses.
+ way, the process is sent SIGTERM ``killed_task_cleanup_time`` after
the timeout elapses, except a
+ language SDK task, which has no timer of its own and is sent SIGTERM
when the timeout elapses.
Review Comment:
Describe the behavior per subclass, or move it to where the override lives.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
