uranusjr commented on code in PR #75446:
URL: https://github.com/apache/airflow/pull/75446#discussion_r4397236616
##########
task-sdk/tests/task_sdk/execution_time/test_supervisor.py:
##########
@@ -1754,6 +1754,43 @@ def _start_activity_subprocess(mocker, *,
execution_timeout):
)
return proc
+ @pytest.mark.parametrize(
+ ("should_retry", "exit_code"),
+ [
+ pytest.param(True, -signal.SIGKILL, id="killed-with-retries"),
+ pytest.param(False, -signal.SIGKILL, id="killed-without-retries"),
+ pytest.param(False, 0, id="exited-cleanly-without-reporting"),
+ ],
+ )
+ def test_execution_timeout_reported_as_reason(self, mocker, should_retry,
exit_code):
Review Comment:
Gaps
* Exit 0 without reporting while `should_retry=True`
* An outcome reported after the timeout (e.g. RetryTask) still wins
* The CONFLICT path
* `final_state` for the exit-with-0 case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
