aaiss0927 commented on PR #75809: URL: https://github.com/apache/airflow/pull/75809#issuecomment-6464811903
Thanks @Alwaysgaurav1 — that was quick. I re-ran the acceptance probes from my review against 13699b94f and all three pass now; the `complete` semantics also still hold after the `found_difference` cleanup (dropping the `or lang_missing` OR-ing is safe because `build_completeness_report` derives `has_missing` from the summary itself). Nice work tightening the table-mode error path back to upstream order, too. One observation for the record, since the two PRs will be compared: the fix goes beyond the `verify --json` pattern suggested in the review and closely matches #75831's implementation — the `buffer`/`completed` abort-replay in the `finally` block (which isn't in `verify_commands.py`; upstream discards the captured narration on abort) and the `print_completeness_json` / `apply_translation_modifications` structure are the same design, down to naming. That's fine — it's Apache-licensed, and behavioral convergence makes the maintainers' choice simpler — but provenance seemed worth noting. With behavior now effectively equivalent, the substantive remaining difference is the output schema. The `$GITHUB_STEP_SUMMARY` follow-up (@aruadecarvalho on #75772) is building against the shape documented in #75831's "Output shape" section, so whichever PR lands, it would be good to settle on one schema before consumers ship. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
