Copilot commented on code in PR #76231:
URL: https://github.com/apache/airflow/pull/76231#discussion_r4436159805
##########
providers/fab/tests/unit/fab/auth_manager/test_fab_auth_manager.py:
##########
@@ -446,6 +451,33 @@ def test_create_token_wrong_values(self, username,
password, auth_manager_with_a
headers={}, body={"username": username, "password": password}
)
+ @pytest.mark.parametrize("auth_type", [AUTH_OAUTH, AUTH_REMOTE_USER])
+ def test_create_token_other_auth_types(self, auth_type,
auth_manager_with_appbuilder):
+ security_manager = Mock()
Review Comment:
Please give these new security-manager mocks a spec: unrestricted `Mock()`
instances accept nonexistent authentication methods and can hide interface
mistakes in the regression tests. Use the already-imported
`FabAirflowSecurityManagerOverride` as the spec here and at line 469.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
