bbovenzi commented on code in PR #76842:
URL: https://github.com/apache/airflow/pull/76842#discussion_r4530772535
##########
airflow-core/docs/administration-and-deployment/plugins.rst:
##########
@@ -327,6 +327,12 @@ definitions in Airflow.
"icon": "https://example.com/icon.svg";,
# Optional dark icon for the dark theme, url to an svg file. If not
provided, "icon" will be used for both light and dark themes.
"icon_dark_mode": "https://example.com/dark_icon.svg";,
+ # Optional flag, only relevant when the view renders as a tab
(destination "dag", "dag_run", "task",
+ # "task_instance" or "asset"). When True, the tab shows its icon
beside the name. When False, the tab shows
+ # only its name. Either way, when the tab bar is 600px wide or less,
tabs show only their icon. Has no
+ # effect without "icon" (an "icon_dark_mode" alone is not enough).
Defaults to False. Supported in
+ # Airflow 3.5 and later; earlier versions ignore it.
Review Comment:
```suggestion
# effect without "icon" (an "icon_dark_mode" alone is not enough).
Defaults to False. Supported in
# Airflow 3.4.1 and later; earlier versions ignore it.
```
##########
airflow-core/docs/administration-and-deployment/plugins.rst:
##########
@@ -366,6 +372,12 @@ definitions in Airflow.
"icon": "https://example.com/icon.svg";,
# Optional dark icon for the dark theme, url to an svg file. If not
provided, "icon" will be used for both light and dark themes.
"icon_dark_mode": "https://example.com/dark_icon.svg";,
+ # Optional flag, only relevant when the app renders as a tab
(destination "dag", "dag_run", "task",
+ # "task_instance" or "asset"). When True, the tab shows its icon
beside the name. When False, the tab shows
+ # only its name. Either way, when the tab bar is 600px wide or less,
tabs show only their icon. Has no
+ # effect without "icon" (an "icon_dark_mode" alone is not enough).
Defaults to False. Supported in
+ # Airflow 3.5 and later; earlier versions ignore it.
Review Comment:
```suggestion
# effect without "icon" (an "icon_dark_mode" alone is not enough).
Defaults to False. Supported in
# Airflow 3.4.1 and later; earlier versions ignore it.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
![https://example.com/icon.svg"](https://example.com/icon.svg"){kind=link}
![https://example.com/dark_icon.svg"](https://example.com/dark_icon.svg"){kind=link}