kvnli216 commented on code in PR #76842:
URL: https://github.com/apache/airflow/pull/76842#discussion_r4530853887
##########
airflow-core/src/airflow/ui/src/layouts/Details/NavTabs.tsx:
##########
@@ -44,6 +45,27 @@ const INDICATOR_HEIGHT = "2px";
const trimTrailingSlash = (path: string) => path.replace(/\/$/u, "");
+const reserveBoldWidth = {
+ content: "attr(data-label)",
+ fontWeight: "bold",
+ height: 0,
+ overflow: "hidden",
+ visibility: "hidden",
+};
+
+const TabLabel = ({ label }: { readonly label: string }) => (
+ <Box
+ _after={reserveBoldWidth}
Review Comment:
Yeah the bold-width is more of a general bug fix for the UI to prevent the
tab widths from widening when the text bolds on hover/focus. I noticed it when
adding the icon + label feature but wasn't sure if it was ok to bundle into the
pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
