Lee-W commented on code in PR #71072:
URL: https://github.com/apache/airflow/pull/71072#discussion_r4583741765
##########
airflow-core/src/airflow/jobs/scheduler_job_runner.py:
##########
@@ -2521,28 +2552,22 @@ def _create_dagruns_for_partitioned_asset_dags(self,
session: Session) -> set[st
meantime, in which case the stale-fingerprint cleanup below drops it
instead.
"""
# Cap per-tick work so the scheduler transaction stays bounded and
other
- # scheduling work isn't starved. Remaining APDRs drain across
subsequent ticks.
- # FIFO is intentional: the oldest pending APDR fires first. A
persistently
- # unsatisfiable APDR at the head (e.g. broken mapper, upstream that
will
- # never arrive) blocks newer ones until an operator removes it or fixes
- # the underlying mapper. We surface the stuck state rather than
silently
- # rotating past it.
- # `with_row_locks(skip_locked=True)` mirrors the sibling ADRQ claim
path:
- # in HA two schedulers can otherwise both grab the same satisfied APDR
- # and race the `created_dag_run_id` UPDATE, orphaning whichever DagRun
- # loses. The `id` tiebreaker on `order_by` keeps LIMIT deterministic
when
- # two APDRs share a `created_at` under bulk asset-event ingestion.
- # SQLite is single-writer and silently drops `FOR UPDATE`, which is
fine.
+ # scheduling work isn't starved; the remainder drains over subsequent
ticks.
+ # FIFO is intentional: a persistently unsatisfiable APDR at the head
(e.g.
+ # broken mapper, upstream that will never arrive) blocks newer ones
until an
+ # operator removes it or fixes the mapper, surfacing the stuck state
rather
+ # than silently rotating past it.
+ # `with_row_locks(skip_locked=True)` mirrors the sibling ADRQ claim
path: in
+ # HA two schedulers can otherwise both grab the same satisfied APDR
and race
+ # the `created_dag_run_id` UPDATE, orphaning whichever DagRun loses.
The `id`
+ # tiebreaker on `order_by` keeps LIMIT deterministic when two APDRs
share a
+ # `created_at` under bulk asset-event ingestion. SQLite is
single-writer and
+ # silently drops `FOR UPDATE`, which is fine.
Review Comment:
Not really needed. Reverted it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]