Lee-W commented on code in PR #71072:
URL: https://github.com/apache/airflow/pull/71072#discussion_r4583770050


##########
airflow-core/src/airflow/jobs/scheduler_job_runner.py:
##########
@@ -400,6 +424,12 @@ def __init__(
         self._multi_team = conf.getboolean("core", "multi_team")
         self._dag_tags_in_metrics = conf.getboolean("metrics", 
"dag_tags_in_metrics", fallback=False)
         self._max_partition_dag_runs_per_loop = MAX_PARTITION_DAG_RUNS_PER_LOOP
+        # Edge-triggers the "partition Dag run cap reached" audit Log rows: 
the dag_ids whose row
+        # was committed during the current backlog episode. Cleared by
+        # `_report_partition_cap_backlog` when the backlog is at or below the 
cap.
+        # Process-local: each scheduler in an HA deployment writes its own 
audit row per Dag per
+        # episode; cross-process de-duplication would need a DB read per 
callback run.

Review Comment:
   I think duplication is acceptable. We can change it if someone shouts. 
Change the comment to say the set is deliberately not de-duplicated across 
schedulers and that each scheduler writes its own row.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to