SachinyadavAug20 commented on code in PR #77282:
URL: https://github.com/apache/airflow/pull/77282#discussion_r4631509097
##########
providers/amazon/src/airflow/providers/amazon/aws/auth_manager/aws_auth_manager.py:
##########
@@ -538,7 +538,10 @@ def filter_authorized_variables(
}
def get_url_login(self, **kwargs) -> str:
- return urljoin(self.apiserver_endpoint,
f"{AUTH_MANAGER_FASTAPI_APP_PREFIX}/login")
+ login_url = urljoin(self.apiserver_endpoint,
f"{AUTH_MANAGER_FASTAPI_APP_PREFIX}/login")
+ if next_url := kwargs.get("next_url"):
Review Comment:
Good point @vincbeck! You're totally right that in core Airflow's
`/auth/login` route today, `get_url_login()` is called without arguments and
core appends `next` itself.
The main idea here was just consistency across auth managers:
`KeycloakAuthManager` (#76362), `FabAuthManager` (#73134), and
`SimpleAuthManager` (#67483) all support `next_url` in
`get_url_login(**kwargs)` for any direct callers or custom integrations, while
`AwsAuthManager` was the only one that silently ignored it.
If having that parity across auth managers makes sense to you, happy to keep
it! But if you feel it's redundant since core doesn't use it right now, I'm
also completely fine closing this out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]