SachinyadavAug20 commented on code in PR #77282:
URL: https://github.com/apache/airflow/pull/77282#discussion_r4631511192
##########
providers/amazon/tests/unit/amazon/aws/auth_manager/test_aws_auth_manager.py:
##########
@@ -944,9 +944,17 @@ def test_filter_authorized_assets_empty(self,
auth_manager, test_user):
assert auth_manager.filter_authorized_assets(assets=[],
user=test_user, method="GET") == set()
- def test_get_url_login(self, auth_manager):
- result = auth_manager.get_url_login()
- assert result == f"{AUTH_MANAGER_FASTAPI_APP_PREFIX}/login"
+ @pytest.mark.parametrize(
+ ("kwargs", "expected"),
+ [
+ ({}, f"{AUTH_MANAGER_FASTAPI_APP_PREFIX}/login"),
+ ({"next_url": "/dags/my_dag"},
f"{AUTH_MANAGER_FASTAPI_APP_PREFIX}/login?next=%2Fdags%2Fmy_dag"),
+ ({"next_url": None}, f"{AUTH_MANAGER_FASTAPI_APP_PREFIX}/login"),
Review Comment:
Good catch! Removed that test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]