mik-laj commented on issue #7316: [AIRFLOW-6699] Parameterize weekday sensor 
tests
URL: https://github.com/apache/airflow/pull/7316#issuecomment-580946162
 
 
   @coopergillan  I see that you like order in tests. Wouldn't you like to 
organize one file?  
   
https://github.com/apache/airflow/blob/master/tests/providers/apache/hive/operators/test_hive.py#L29-L40
   This file contains tests for many unrelated components. I think it would be 
useful to transfer some tests to other files.
   Here is an example: 
https://github.com/PolideaInternal/airflow/commit/a91b61222a7790c6daeb59f3bb2d90f1a2cc1c40
   To avoid conflicts you can do it in one PR, but it would be useful for each 
move to be in a separate commit. This will facilitate the review. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to