coopergillan commented on issue #7316: [AIRFLOW-6699] Parameterize weekday sensor tests URL: https://github.com/apache/airflow/pull/7316#issuecomment-580951357 Sure, I would love to give that a shot. Thanks! On Fri, Jan 31, 2020 at 16:53 Kamil Breguła <[email protected]> wrote: > @coopergillan <https://github.com/coopergillan> I see that you like order > in tests. Wouldn't you like to organize one file? > > https://github.com/apache/airflow/blob/master/tests/providers/apache/hive/operators/test_hive.py#L29-L40 > This file contains tests for many unrelated components. I think it would > be useful to transfer some tests to other files. > Here is an example: PolideaInternal@a91b612 > <https://github.com/PolideaInternal/airflow/commit/a91b61222a7790c6daeb59f3bb2d90f1a2cc1c40> > To avoid conflicts you can do it in one PR, but it would be useful for > each move to be in a separate commit. This will facilitate the review. > > — > You are receiving this because you were mentioned. > > > Reply to this email directly, view it on GitHub > <https://github.com/apache/airflow/pull/7316?email_source=notifications&email_token=ACSELCXBOLPFPD3ENLHDQOLRASTU3A5CNFSM4KONYK72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKQIR4Q#issuecomment-580946162>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ACSELCQ5GLIHM547JBRVIXDRASTU3ANCNFSM4KONYK7Q> > . > -- Cooper
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
