jstern commented on a change in pull request #7133: [AIRFLOW-6535] add 
exception to fail without retry
URL: https://github.com/apache/airflow/pull/7133#discussion_r374728353
 
 

 ##########
 File path: docs/conf.py
 ##########
 @@ -207,9 +207,12 @@
 ROOT_DIR = os.path.abspath(os.path.join(os.path.dirname(__file__), os.pardir))
 
 # Generate top-level
+
+allowed_top_level = ("exceptions.py",)
 
 Review comment:
   ah, was wondering if this would come up. @potiuk suggested that I should add 
documentation to the concepts section, and it felt incomplete to me to add that 
without linking to the exceptions api docs. all modules at the top level 
(airflow/*.py) are excluded from the documentation and my link to the 
exceptions api doc could not be rendered and was breaking the docs build. 
adding this ... exception :) ... fixed that
   
   i'm happy to take any direction whether that's leaving this as-is, removing 
the links to the exception api docs, or something in-between. just let me know 
what you'd prefer

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to