jstern commented on a change in pull request #7133: [AIRFLOW-6535] add
exception to fail without retry
URL: https://github.com/apache/airflow/pull/7133#discussion_r374728384
##########
File path: tests/models/test_taskinstance.py
##########
@@ -1475,6 +1476,8 @@ def test_handle_failure(self):
dag=dag)
ti1 = TI(task=task1, execution_date=start_date)
ti1.state = State.FAILED
+ ti1.start_date = start_date
+ ti1.end_date = end_date
Review comment:
the original structure of the method under test had a wide scope for the
try/except block that was intended to log when we're unable to send an email
and move on. i think TypeError's due to these attributes being none were being
caught by that block and allowing the test to complete without error
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
