potiuk commented on a change in pull request #7371: [AIRFLOW-6737] Enable 
kubernetes diagnostics for all kubernetes tests
URL: https://github.com/apache/airflow/pull/7371#discussion_r375370266
 
 

 ##########
 File path: tests/runtime/kubernetes/test_kubernetes_executor.py
 ##########
 @@ -66,6 +64,10 @@ def setUp(self):
     def tearDown(self):
         self.session.close()
 
+    @classmethod
+    def tearDownClass(cls) -> None:
+        dump_kubernetes_logs()
 
 Review comment:
   Thought about it but it's better to do this at the end as usually when the 
first test fails, the rest will as well due to kubernetes misconfiguration. 
This is really here in order to see that kubernetes was misconfigured, so I 
prefer to see all the logs after all the tests complete.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to