potiuk commented on a change in pull request #7371: [AIRFLOW-6737] Enable
kubernetes diagnostics for all kubernetes tests
URL: https://github.com/apache/airflow/pull/7371#discussion_r375375049
##########
File path: tests/runtime/kubernetes/test_kubernetes_executor.py
##########
@@ -66,6 +64,10 @@ def setUp(self):
def tearDown(self):
self.session.close()
+ @classmethod
+ def tearDownClass(cls) -> None:
+ dump_kubernetes_logs()
Review comment:
I also thought about using post-process but I only want to run it only when
the kubernetes tests are run - I prefer to do it in the tearDownClass for now
rather than checking additionally in the post_process hook that kubernetes env
is set.... But maybe that makes more sense indeed. I will think about it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
