ashb commented on a change in pull request #7376: [AIRFLOW-2906] Add datadog(dogstatsd) support to send airflow metrics URL: https://github.com/apache/airflow/pull/7376#discussion_r375924563
########## File path: airflow/config_templates/default_airflow.cfg ########## @@ -667,6 +667,23 @@ statsd_allow_list = # def func_name(stat_name: str) -> str: stat_name_handler = +# Dogstatsd +# (https://docs.datadoghq.com/developers/metrics/dogstatsd_metrics_submission/?tab=python#metric-tagging) +dogstatsd_on = False +dogstatsd_host = localhost Review comment: I would instead have done this as a single flag -- such as `stasts_datadog_enabled = True`, because all the rest of the configs are the same, and I can't see a case when a user would want both plain statsd and dogstatsd enable. Thoughts? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
