chandulal commented on a change in pull request #7376: [AIRFLOW-2906] Add 
datadog(dogstatsd) support to send airflow metrics
URL: https://github.com/apache/airflow/pull/7376#discussion_r376191046
 
 

 ##########
 File path: airflow/config_templates/default_airflow.cfg
 ##########
 @@ -667,6 +667,23 @@ statsd_allow_list =
 # def func_name(stat_name: str) -> str:
 stat_name_handler =
 
+# Dogstatsd
+# 
(https://docs.datadoghq.com/developers/metrics/dogstatsd_metrics_submission/?tab=python#metric-tagging)
+dogstatsd_on = False
+dogstatsd_host = localhost
 
 Review comment:
   Yes, there are some common configs and no need to duplicate it. I like your 
idea to add necessary configs only.
   I am okay with your suggestions. If we go with this,  we just need to add 
only two more configs. 
   
   `stasts_datadog_enabled = False`
   `stasts_datadog_tags =`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to