ashb commented on a change in pull request #7276: [AIRFLOW-5391] Do not run 
skipped tasks when they are cleared
URL: https://github.com/apache/airflow/pull/7276#discussion_r379328108
 
 

 ##########
 File path: airflow/models/skipmixin.py
 ##########
 @@ -98,3 +98,17 @@ def skip_all_except(self, ti: TaskInstance, 
branch_task_ids: Union[str, Iterable
 
             self.log.info("Skipping tasks %s", [t.task_id for t in skip_tasks])
             self.skip(dag_run, ti.execution_date, skip_tasks)
+
+    def evaluate_skip_condition(self, xcom_value: Any, downstream_ti: 
TaskInstance):
+        """
+        Evalutes the xcom_value of the SkipMixin itself and decides if a 
downstream task
+        should be skipped.
 
 Review comment:
   This doc needs expanding to say when this is called (as it's not clear 
without reading the rest of this code) so people with custom operators know 
what to do.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to