ashb commented on a change in pull request #7276: [AIRFLOW-5391] Do not run
skipped tasks when they are cleared
URL: https://github.com/apache/airflow/pull/7276#discussion_r380217423
##########
File path: airflow/models/skipmixin.py
##########
@@ -88,13 +131,23 @@ def skip_all_except(self, ti: TaskInstance,
branch_task_ids: Union[str, Iterable
# is also a downstream task of the branch task, we exclude it from
skipping.
branch_downstream_task_ids = set() # type: Set[str]
for b in branch_task_ids:
- branch_downstream_task_ids.update(dag.
- get_task(b).
-
get_flat_relative_ids(upstream=False))
+ branch_downstream_task_ids.update(
+ dag.get_task(b).get_flat_relative_ids(upstream=False)
+ )
- skip_tasks = [t for t in downstream_tasks
- if t.task_id not in branch_task_ids and
- t.task_id not in branch_downstream_task_ids]
+ skip_tasks = [
+ t
+ for t in downstream_tasks
+ if t.task_id not in branch_task_ids
+ and t.task_id not in branch_downstream_task_ids
+ ]
self.log.info("Skipping tasks %s", [t.task_id for t in skip_tasks])
- self.skip(dag_run, ti.execution_date, skip_tasks)
+ with create_session() as session:
+ self._set_state_to_skipped(
+ dag_run, ti.execution_date, skip_tasks, session=session
+ )
+ session.commit()
+ ti.xcom_push(
+ key=XCOM_SKIPMIXIN_KEY, value={"followed": branch_task_ids}
Review comment:
```suggestion
key=XCOM_SKIPMIXIN_KEY, value={XCOM_SKIPMIXIN_FOLLOWED:
branch_task_ids}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
