[
https://issues.apache.org/jira/browse/AIRFLOW-6883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042618#comment-17042618
]
ASF GitHub Bot commented on AIRFLOW-6883:
-----------------------------------------
ashb commented on pull request #7505: [AIRFLOW-6883] Speed up import of
airflow.utils.log.file_task_hanlder
URL: https://github.com/apache/airflow/pull/7505
This module imports form airflow.models, which in turn means we impor
all the other modules (which we can fix in a later issue) -- but there
is still no need to import that module here as it is only used for type
checking.
So lets use the already existing guard built in to the typing module.
On my machine this speeds up `import airflow` from 0.74s to 0.44s
---
Issue link: WILL BE INSERTED BY
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN =
JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with
`[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Improve import time of airflow moudle
> -------------------------------------
>
> Key: AIRFLOW-6883
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6883
> Project: Apache Airflow
> Issue Type: Improvement
> Components: core
> Affects Versions: 2.0.0
> Reporter: Ash Berlin-Taylor
> Assignee: Ash Berlin-Taylor
> Priority: Major
>
> Importing the file_task_handler is importing TaksInstance (which currently
> pulls in much of the rest of airflow) -- but it is only used for type
> checking, so can be put behind a guard
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
