ashb commented on a change in pull request #7505: [AIRFLOW-6883] Speed up import of airflow.utils.log.file_task_hanlder URL: https://github.com/apache/airflow/pull/7505#discussion_r382924359
########## File path: airflow/utils/log/file_task_handler.py ########## @@ -18,15 +18,17 @@ """File logging handler for tasks.""" import logging import os -from typing import Optional Review comment: _Even_ if importing this one module was quick, it's still an extra import that is not needed at run time. That's a number of directory searches looking for the this one file, and a opening a file, parsing it etc. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
