potiuk commented on a change in pull request #7505: [AIRFLOW-6883] Speed up import of airflow.utils.log.file_task_hanlder URL: https://github.com/apache/airflow/pull/7505#discussion_r382925145
########## File path: airflow/utils/log/file_task_handler.py ########## @@ -18,15 +18,17 @@ """File logging handler for tasks.""" import logging import os -from typing import Optional Review comment: > (And the number of directory searches goes up if we use implicit namespaces.) Yeah. I already fully abandoned this idea. I simply stopped being fan of implicit packages. We should not use them. There were many problems in our code that we would have to solve and gain nothing in return, behavior of some code changes when there are implicit packages and there are still many tools/packages (like sphinx but many others) that do not work well with implicit packages yet. It makes little sense to use implicit packages now that we can install providers packages without them. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
