dstandish commented on a change in pull request #6376: [AIRFLOW-5705] Add creds backend and support for AWS SSM URL: https://github.com/apache/airflow/pull/6376#discussion_r389203393
########## File path: airflow/creds/__init__.py ########## @@ -0,0 +1,74 @@ +# -*- coding: utf-8 -*- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +""" +Creds framework provides means of getting connection objects from various sources e.g. the following: +* Environment variables +* Metatsore database +* AWS SSM Parameter store +""" + +from abc import ABC, abstractmethod +from typing import List + +from airflow import AirflowException, conf +from airflow.models import Connection +from airflow.utils.module_loading import import_string + +CONN_ENV_PREFIX = "AIRFLOW_CONN_" + + +class BaseCredsBackend(ABC): + """ + Abstract base class to provide connection objects given a conn_id Review comment: i spoke to the thinking [in this comment](https://github.com/apache/airflow/pull/6376#discussion_r389202690). i am not attached to the name. does group feel `BaseConnectionBackend` is the right name? alternatively can update description to be more compatible. e.g. ``` Abstract base class to retrieve creds given a conn_id and construct a Connection object ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
