dstandish commented on a change in pull request #6376: [AIRFLOW-5705] Add creds 
backend and support for AWS SSM
URL: https://github.com/apache/airflow/pull/6376#discussion_r389404457
 
 

 ##########
 File path: airflow/config_templates/default_airflow.cfg
 ##########
 @@ -248,6 +248,16 @@ dag_processor_manager_log_location = 
{AIRFLOW_HOME}/logs/dag_processor_manager/d
 # Default to use task handler.
 task_log_reader = task
 
+[creds_backend]
+# List of creds backend classes to use in order of desired search path
+class_list = 
airflow.creds.environment_variables.EnvironmentVariablesCredsBackend, 
airflow.creds.metastore.MetastoreCredsBackend
+
+# Use when using AWS SSM / 
airflow.providers.amazon.aws.creds.ssm.AwsSsmCredsBackend as creds provider
+# If prefix is ``/airflow``, then example param path is 
``/airflow/AIRFLOW_CONN_SMTP_DEFAULT``
+# Use same URI format as you would with env vars, or ``conn_uri`` CLI param.
+aws_ssm_prefix = /airflow
+aws_ssm_profile_name =
 
 Review comment:
   i am totally fine with this idea.  makes configuration simpler and more 
generic.   
   
   the only sticking point would be if someone thinks we really should support 
multiple backends, OR if someone thinks it's important to be able to customize 
search path (e.g. database first, then check SSM, or database then env var)
   
   i guess i'll let this comment linger for a day-ish and barring an objection 
make the change.
   
   re multiple ssm prefix... to support this we could do `aws_ssm_prefix_list` 
instead... but... like you indicated, probably not necessary?
   
   thanks :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to