feluelle commented on a change in pull request #7731: [AIRFLOW-7068] Create EC2 Hook, Operator and Sensor URL: https://github.com/apache/airflow/pull/7731#discussion_r395982917
########## File path: airflow/providers/amazon/aws/hooks/ec2.py ########## @@ -0,0 +1,98 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +import time +from typing import Optional + +from airflow.providers.amazon.aws.hooks.base_aws import AwsBaseHook + + +class EC2Hook(AwsBaseHook): + """ + Interact with AWS EC2 Service. + """ + + def __init__(self, + region_name: Optional[str] = None, + *args, + **kwargs): + self.region_name = region_name + self.conn = None + super().__init__(*args, **kwargs) + + def get_conn(self): + """ + Return self.conn, if it is None initialize ec2 resource object. + + :return: ec2 resource + :rtype: boto3.resource + """ + # set self.conn in first call + if not self.conn: + self.conn = self.get_resource_type("ec2", self.region_name) + return self.conn + + def get_instance(self, instance_id: str): + """ + Get EC2 instance by id and return it. + + :param instance_id: id of the AWS EC2 instance + :type instance_id: str + :return: Instance object + :rtype: ec2.Instance + """ + return self.get_conn().Instance(id=instance_id) + + def get_instance_state(self, instance_id: str) -> str: + """ + Get EC2 instance state by id and return it. + + :param instance_id: id of the AWS EC2 instance + :type instance_id: str + :return: current state of the instance + :rtype: str + """ + return self.get_instance(instance_id=instance_id).state["Name"] + + def wait_for_state(self, + instance_id: str, + target_state: str, + check_interval: float) -> None: + """ + Wait EC2 instance until its state is equal to the target_state. + + :param instance_id: id of the AWS EC2 instance + :type instance_id: str + :param target_state: target state of instance + :type target_state: str + :param check_interval: time in seconds that the job should wait in + between each instance state checks until operation is completed + :type check_interval: float + :return: None + :rtype: None + """ + instance_state = self.get_instance_state( + instance_id=instance_id + ) + while instance_state != target_state: + self.log.info("instance state: %s", instance_state) + time.sleep(check_interval) + instance_state = self.get_instance_state( + instance_id=instance_id + ) Review comment: ```suggestion while True: instance_state = self.get_instance_state( instance_id=instance_id ) self.log.info("instance state: %s", instance_state) if instance_state == target_state: break time.sleep(check_interval) ``` WDYT? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
