mustafagok commented on a change in pull request #7731: [AIRFLOW-7068] Create EC2 Hook, Operator and Sensor URL: https://github.com/apache/airflow/pull/7731#discussion_r392914054
########## File path: airflow/providers/amazon/aws/sensors/ec2.py ########## @@ -0,0 +1,78 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +from typing import Optional + +from airflow.exceptions import AirflowException +from airflow.providers.amazon.aws.hooks.ec2 import EC2Hook +from airflow.sensors.base_sensor_operator import BaseSensorOperator +from airflow.utils.decorators import apply_defaults + + +class EC2Sensor(BaseSensorOperator): + """ + Check the state of the AWS EC2 instance until + state of the instance become equal to the target state. + + :param target_state: target state of instances + :type target_state: str + :param instance_id: id of the AWS EC2 Instances + :type instance_id: str + :param region_name: (optional) aws region name associated with the client + :type region_name: Optional[str] + """ + + template_fields = ["target_state", "region_name"] + ui_color = "#cc8811" + ui_fgcolor = "#ffffff" + valid_states = ["running", "stopped"] + + @apply_defaults + def __init__(self, + target_state: str, + instance_id: str, + aws_conn_id: str = "aws_default", + region_name: Optional[str] = None, + *args, + **kwargs): + if target_state not in self.valid_states: + raise AirflowException(f"Invalid target_state: {target_state}") + super().__init__(*args, **kwargs) + self.target_state = target_state + self.instance_id = instance_id + self.aws_conn_id = aws_conn_id + self.region_name = region_name + self.hook = self.get_hook() Review comment: I didn't know that, fixed, thank you. P.S.: There are some bad practices in other operators. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
